Topic on User talk:GethN7

Inline spoilers

19
Idris (talkcontribs)
GethN7 (talkcontribs)

Sweet. We have some gadget code that does something similar, but I like your idea even better.

Was going to add you code to our site gadgets (you can change these in user preferences), will be sure to credit you properly. :D

Also, welcome to ATT, hope you have fun here!

Idris (talkcontribs)

Thanks, but I think that you need to remove "!important" from MediaWiki:Common.css for the gadget to function.

GethN7 (talkcontribs)

Done. If there are any further issues, do let me know.

GethN7 (talkcontribs)

Think I fixed things, but Miraheze's site caching may make it take a day or two for certain changes to percolate globally.

I also tagged in a fellow admin who does our code to make sure I didn't screw anything up, since he did our default spoiler CSS/JS code as well.

Idris (talkcontribs)
Idris (talkcontribs)
GethN7 (talkcontribs)

I just did the changes, they seem to be working well. If not, page User:Labster.

Idris (talkcontribs)
Labster (talkcontribs)

Can we please test our changes to places like {{spoiler}} before deploying? Any changes there require several hours of work rebuilding wiki pages. Thanks.

GethN7 (talkcontribs)

Whoops, my bad. Could you work on this further, plz? Looks simple, but given what it changes, I rather have someone better versed in this do so.

Okay, so the click spoiler gadget now works right. Thanks Idris, it looks nice!

We still seem to have issues with our other spoiler revealing gadgets, so User:Labster, please look into that when you have the time.

Idris (talkcontribs)
GethN7 (talkcontribs)

Much appreciated, will do that.

Also, I notice you hail from Kings Wiki. If we don't already have a page on them, feel free to make one. :)

Idris (talkcontribs)

No problem. Thanks.

Kings Wiki is still in early development, its community hasn't reached full fruition yet, and it's still missing articles on key topics. I don't believe that Kings Wiki is ready to be summed up with tropes just yet.

GethN7 (talkcontribs)

Well, if you just want a stub article inviting people to check it out and give a brief overview of it's purpose, we're cool with that if you want, but if you feel it isn't appropriate now, I understand.

In any event, be proud, you're an obvious benefit to both our communities. :)

Labster (talkcontribs)

Back on the topic of click-to-reveal spoilers, the only problem with this is that you can accidentally click a link when trying to reveal a spoiler. Because the spoiler span is the parent of the hyperlinks, maybe bind a click event on links in spoiler tags with event.preventDefault(), but only if the spoiler is hidden. That would still let the click event bubble up to the spoiler span.

GethN7 (talkcontribs)

Noticed that issue myself, could you tweak the code for this to fix that that then?

Labster (talkcontribs)

Done

Labster (talkcontribs)

Wow, {{done}} is pretty impressive in Flow!